Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont publish items that are acquired. #151

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented May 17, 2023

This has been lifted from collective.explicitacquisition.
Needs zopefoundation/Products.CMFCore#129

This is NOT expected to be made available for Plone 5.x.

This has been lifted from collective.explicitacquisition
@mister-roboto
Copy link

@jaroel thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jaroel
Copy link
Member Author

jaroel commented May 17, 2023

This is a draft.

@jaroel jaroel requested a review from jensens May 18, 2023 15:59
@jaroel
Copy link
Member Author

jaroel commented May 18, 2023

Ready for review

@tisto
Copy link
Member

tisto commented Sep 22, 2023

@jaroel the CMFCore PR has been merged, what's the status of this PR?

@jaroel
Copy link
Member Author

jaroel commented Sep 22, 2023

@jenkins-plone-org please run jobs

@jaroel
Copy link
Member Author

jaroel commented Sep 22, 2023

@tisto please have someone have a look. When the tests pass we should be ready to merge this.

setup.py Outdated Show resolved Hide resolved
@jaroel
Copy link
Member Author

jaroel commented Oct 9, 2023

pre-commit.ci autofix

@jaroel
Copy link
Member Author

jaroel commented Oct 9, 2023

pre-commit.ci autofix

@jaroel
Copy link
Member Author

jaroel commented Oct 9, 2023

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees merged commit 809346b into main Oct 10, 2023
15 checks passed
@mauritsvanrees mauritsvanrees deleted the explicitacquisition branch October 10, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants