Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 2.7, 3.6 and 3.7 #156

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Drop Python 2.7, 3.6 and 3.7 #156

merged 5 commits into from
Sep 22, 2023

Conversation

tisto
Copy link
Member

@tisto tisto commented Sep 21, 2023

No description provided.

@mister-roboto
Copy link

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@tisto
Copy link
Member Author

tisto commented Sep 21, 2023

@mauritsvanrees I'd like to create a plone.rest 4.0.0 release that drops Python 2.7 support (too much work) and Python 3.6 and 3.7 (not tested on CI, no official security support any longer). Are you ok with this?

cc @davisagli

davisagli
davisagli reviewed Sep 21, 2023
View reviewed changes
setup.py
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add 3.11 here too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, I can't read :)

mauritsvanrees
mauritsvanrees approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

setup.py Outdated Show resolved Hide resolved
@tisto
Copy link
Member Author

tisto commented Sep 22, 2023

@jenkins-plone-org please run jobs

@tisto tisto merged commit de3266d into master Sep 22, 2023
9 checks passed
@tisto tisto deleted the drop-py27 branch September 22, 2023 07:54
@tisto tisto mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisto @mister-roboto @davisagli @mauritsvanrees