Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre commit tisto #161

Merged
merged 5 commits into from
Oct 1, 2023
Merged

Pre commit tisto #161

merged 5 commits into from
Oct 1, 2023

Conversation

tisto
Copy link
Member

@tisto tisto commented Sep 24, 2023

No description provided.

@mister-roboto
Copy link

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@tisto tisto requested a review from gforcada September 25, 2023 19:10
@tisto
Copy link
Member Author

tisto commented Sep 25, 2023

@gforcada to gain a better understanding of our new coredev best practices I tried to re-create your PR on plone.rest going in small steps. Would you mind having a look?

@tisto
Copy link
Member Author

tisto commented Sep 25, 2023

@jenkins-plone-org please run jobs

davisagli
davisagli approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davisagli
Copy link
Member

@tisto This PR is missing a towncrier entry, and it seems the repo is missing a check for that.

@tisto tisto merged commit 79f1d19 into main Oct 1, 2023
9 checks passed
@tisto tisto deleted the pre-commit-tisto branch October 1, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@gforcada gforcada Awaiting requested review from gforcada

@ericof ericof Awaiting requested review from ericof

@sneridagh sneridagh Awaiting requested review from sneridagh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisto @mister-roboto @davisagli