Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pat-contentbrowser for CatalogSource vocabulary lookups. #359

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

petschki
Copy link
Member

@petschki petschki commented Nov 8, 2024

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

petschki commented Nov 8, 2024

@jenkins-plone-org please run jobs

@petschki petschki requested a review from 1letter November 8, 2024 10:55
Copy link
Contributor

@1letter 1letter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, locally tests are green ;-) Thanks!

@1letter 1letter merged commit 41be8cd into master Nov 9, 2024
10 checks passed
@1letter 1letter deleted the contentbrowser-bugfix branch November 9, 2024 20:53
@petschki
Copy link
Member Author

released in 2.2.0b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants