Skip to content

Commit

Permalink
Misc fix (#43)
Browse files Browse the repository at this point in the history 
* fix css in demo apps

* Update vtk helper to support binary encoding

* update react-vtk-js@1.5.0 to support binary arrays

* Trigger CI

* fix numpy int64/uint64 conversion

* bump react-vtk-js@1.5.1 to fix cell handling from json when points are binary

* Update changelog

* Bump version

Co-authored-by: xhlulu <xinghan@plot.ly>
Co-authored-by: xhlulu <xhlperso@gmail.com>
  • Loading branch information
@jourdain
3 people authored Apr 16, 2021
1 parent 05e2467 commit 8c8b363
Show file tree
Hide file tree
Showing 19 changed files with 1,206 additions and 756 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: dashVtk
Title: React based declarative usage of vtk.js for Dash
Version: 0.0.8
Version: 0.0.9
Description: React based declarative usage of vtk.js for Dash
Depends: R (>= 3.0.2)
Imports:
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "DashVtk"
uuid = "1b08a953-4be3-4667-9a23-818b1eccd4c7"
authors = ["Kitware Inc <sebastien.jourdain@kitware.com> and Plotly Technologies <xinghan@plot.ly>"]
version = "0.0.8"
version = "0.0.9"

This comment has been minimized.

Sign in to view

Copy link
@rpkyle

rpkyle May 19, 2021

Contributor

@JuliaRegistrator register

[deps]
Dash = "1b08a953-4be3-4667-9a23-3db579824955"
Expand Down
8 changes: 4 additions & 4 deletions R/internal.R
View file
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
.dashVtk_js_metadata <- function() {
deps_metadata <- list(`dash_vtk` = structure(list(name = "dash_vtk",
version = "0.0.8", src = list(href = NULL,
version = "0.0.9", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_vtk.min.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashVtk",
all_files = FALSE), class = "html_dependency"),
`dash_vtk` = structure(list(name = "dash_vtk",
version = "0.0.8", src = list(href = NULL,
version = "0.0.9", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_vtk.min.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashVtk",
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_vtk` = structure(list(name = "dash_vtk",
version = "0.0.8", src = list(href = NULL,
version = "0.0.9", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'async-ReactVTK.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashVtk",
all_files = FALSE, async = TRUE), class = "html_dependency"),
`dash_vtk` = structure(list(name = "dash_vtk",
version = "0.0.8", src = list(href = NULL,
version = "0.0.9", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'async-ReactVTK.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashVtk",
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,4 @@ You can find the complete API reference in [`docs/REFERENCES.md`](https://github
[dicom-ct-lung]: https://github.com/plotly/dash-vtk/blob/master/demos/dicom-ct-lung/demo.jpg?raw=true
[dicom-mri-brain]: https://github.com/plotly/dash-vtk/blob/master/demos/dicom-mri-brain/demo.jpg?raw=true
[dicom-mri-pancreas]: https://github.com/plotly/dash-vtk/blob/master/demos/dicom-mri-pancreas/demo.jpg?raw=true

2 changes: 1 addition & 1 deletion dash_vtk/async-ReactVTK.js
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_vtk/dash_vtk.min.js
View file

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dash_vtk/package-info.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash_vtk",
"version": "0.0.8",
"version": "0.0.9",
"description": "React based declarative usage of vtk.js for Dash",
"repository": {
"type": "git",
Expand All @@ -26,7 +26,7 @@
"dependencies": {
"@plotly/dash-component-plugins": "^1.2.0",
"ramda": "^0.26.1",
"react-vtk-js": "^1.5.0"
"react-vtk-js": "^1.5.1"
},
"devDependencies": {
"@babel/core": "^7.5.4",
Expand Down
Loading

1 comment on commit 8c8b363

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/37064

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.0.9 -m "<description of version>" 8c8b3632355d90e50b6a7d20db53a9d47e1d12ce
git push origin v0.0.9

Also, note the warning: This looks like a new registration that registers version 0.0.9.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

Please sign in to comment.