-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add faceting support for all figure factory methods #3132
base: master
Are you sure you want to change the base?
Conversation
…or all figure factory functions
@nicolaskruchten, this attempts to resolve #2646. I feel like there sould be more to do than this, but the default spacing seems to be reasonable... |
Thanks! I'll take a look in a couple of weeks as we prepare for the next release of Plotly.py :) For spacing, what sizes of figures did you spot-check/how many rows/how many columns? |
I only checked 2x2. I'll can go back through with 3x3 perhaps, and also provide the scripts I used to check them as that'll probably make validation a little easier for you. |
Yeah, this kind of thing is what we need to come up with a good heuristic for... |
This PR adds facet support to some chart types that currently don't support faceting, so with re-work it could be merged. |
Closes: #4724
Documentation PR
doc/README.md
filedoc-prod
branch OR it targets themaster
branchpx
example if at all possibleplotly.graph_objects as go
/plotly.express as px
/plotly.io as pio
df
fig = <something>
call is high up in each new/modified example (eitherpx.<something>
ormake_subplots
orgo.Figure
)fig.add_*
andfig.update_*
rather thango.Figure(data=..., layout=...)
in every new/modified examplefig.add_shape
andfig.update_xaxes
are used instead of bigfig.update_layout
calls in every new/modified examplefig.show()
is at the end of each new/modified exampleplotly.plot()
andplotly.iplot()
are not used in any new/modified exampleCode PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).