-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAVE test failing #434
Comments
Thank you very much @rianrietveld ! I am still confused, because WAVE is telling us (emphasize from me):
Therefore the label shouldn't be required here, or not? @2ndkauboy Any chance to get this in, even it is already in the comment form? |
@Zodiac1978 hidden refers to type="hidden" and in this case it's a textarea :-) |
We could just add this here: https://github.com/pluginkollektiv/antispam-bee/blob/master/antispam_bee.php#L1281 What about using |
Adding more details (emphasize mine):
TL;DR: Error can be ignored, but the error can easily be prevented if we add the label, what the PR is doing. |
First reported here: https://wordpress.org/support/topic/comment-form-accessibility-compliance/
@Zodiac1978
The solution is to add
aria-label="whatever"
as attribute to the textarea.The automated tool checks if a form control has an accessible name. In this case, even if the form control is hidden from sight and screen reader, it must have an accessible name to pass the WAVE test.
This can be easily solved by adding an aria-label like
aria-label="comment"
The aria-label can be anything, because it is never announced or visible.
And then it passes WAVE :-)
I made a codepen with both options, with and without adding aria-label. The the first one fails, the second one passes in WAVE.
Originally posted by @rianrietveld in #292 (comment)
The text was updated successfully, but these errors were encountered: