Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements on plugin i18n #545

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Small improvements on plugin i18n #545

merged 3 commits into from
Jan 7, 2024

Conversation

pedro-mendonca
Copy link
Contributor

Hi,

Thanks for the awesome plugin.

While contributing to its translation, found the below issues that I'm suggesting to fix in this PR.

  • Singular/plural translation for %s Blocked string on the dashboard widget count.
  • Some double spaces in strings.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pluginkollektiv pluginkollektiv deleted a comment from sonarqubecloud bot Jan 7, 2024
Zodiac1978
Zodiac1978 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zodiac1978 Zodiac1978 merged commit 58014ba into pluginkollektiv:master Jan 7, 2024
11 checks passed
@stklcode stklcode added this to the 2.11.6 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zodiac1978 Zodiac1978 Zodiac1978 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.6
Development

Successfully merging this pull request may close these issues.
3 participants
@pedro-mendonca @Zodiac1978 @stklcode