Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup seems to be deprecated and is now markupsafe apparently #137

Open
adamantic opened this issue Oct 3, 2023 · 6 comments
Open

Markup seems to be deprecated and is now markupsafe apparently #137

adamantic opened this issue Oct 3, 2023 · 6 comments

Comments

@adamantic
Copy link

Markup seems to be deprecated and is now markupsafe apparently

File "/app/.heroku/python/lib/python3.9/site-packages/flask_table/init.py", line 1, in
2023-10-03T10:46:35.754301+00:00 app[web.1]: from .table import Table, create_table
2023-10-03T10:46:35.754301+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.9/site-packages/flask_table/table.py", line 5, in
2023-10-03T10:46:35.754301+00:00 app[web.1]: from flask import Markup
2023-10-03T10:46:35.754301+00:00 app[web.1]: ImportError: cannot import name 'Markup' from 'flask' (/app/.heroku/python/lib/python3.9/site-packages/flask/init.py)

@mikehooper
Copy link

I've got the same issue:

File "/home/pi/uvrobot/main.py", line 8, in
from tables import Results, SubSections
File "/home/pi/uvrobot/tables.py", line 1, in
from flask_table import Table, Col, LinkCol
File "/home/pi/uvrobot/env/lib/python3.11/site-packages/flask_table/init.py", line 1, in
from .table import Table, create_table
File "/home/pi/uvrobot/env/lib/python3.11/site-packages/flask_table/table.py", line 5, in
from flask import Markup
ImportError: cannot import name 'Markup' from 'flask' (/home/pi/uvrobot/env/lib/python3.11/site-packages/flask/init.py)

@jbhanks
Copy link

jbhanks commented Nov 1, 2023

Same. I just patched it manually on my installation, but it would be nice to get it fixed in the repos.

@gmassman
Copy link

gmassman commented Jan 3, 2024

I opened PR #141 to fix this issue, waiting on approval from @plumdog.

@jbhanks
Copy link

jbhanks commented Jan 30, 2024

I opened PR #141 to fix this issue, waiting on approval from @plumdog.

I hope it gets merged soon, it's annoying to have a custom patch as part of my installation scripts. It's a one-line change, has @plumdog given up on this project? If so, should it be forked and submitted to PyPi as a replacement?

@charlesmartin14
Copy link

I alo have this problem

@yaalaa
Copy link

yaalaa commented Apr 28, 2024

+1 please fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants