Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add log driver settings to DeploymentSettings #1703

Merged
merged 4 commits into from
Dec 20, 2024
Merged

feat: add log driver settings to DeploymentSettings #1703

merged 4 commits into from
Dec 20, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Dec 20, 2024

add log driver settings to DeploymentSettings

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@zreigz zreigz added the enhancement New feature or request label Dec 20, 2024
@michaeljguarino
Copy link
Member

doesn't this require controller interaction as well?

@zreigz
Copy link
Member Author

zreigz commented Dec 20, 2024 •
edited
Loading

doesn't this require controller interaction as well?

Yes, but LoggingSettings are missing in DeploymentSettingsAttributes
Can you extend it in the API?

@michaeljguarino
Copy link
Member

doesn't this require controller interaction as well?

Yes, but LoggingSettings are missing in DeploymentSettingsAttributes Can you extend it in the API?

Oh my fault, merged my pr w/ that change now

@zreigz
Copy link
Member Author

zreigz commented Dec 20, 2024

@michaeljguarino PTAL

@michaeljguarino michaeljguarino merged commit ce29cf2 into master Dec 20, 2024
14 checks passed
@michaeljguarino michaeljguarino deleted the log-driver-deployment-settings branch December 20, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @michaeljguarino