Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have charts be specified as raw strings #575

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

michaeljguarino
Copy link
Member

Summary

These aren't large or secret data, so just an inline string is the appropriate typing here.

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Visit the preview URL for this PR (updated for commit e310b15):

https://pluralsh-console--pr575-minor-operator-fix-2mgmo91n.web.app

(expires Tue, 09 Jan 2024 20:49:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

These aren't large or secret data, so just an inline string is the appropriate typing here.
@michaeljguarino michaeljguarino merged commit 85f34ba into master Jan 2, 2024
11 of 14 checks passed
@michaeljguarino michaeljguarino deleted the minor-operator-fix branch January 2, 2024 21:24
snikch pushed a commit to snikch/plural-console that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant