Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update pipelines controller #589

Merged
merged 26 commits into from
Jan 10, 2024
Merged

feat: Update pipelines controller #589

merged 26 commits into from
Jan 10, 2024

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Jan 5, 2024 •
edited
Loading

Zrzut ekranu 2024-01-8 o 16 41 29

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit eb3cbb7):

https://pluralsh-console--pr589-pipelines-model-8ys6ln5w.web.app

(expires Wed, 17 Jan 2024 09:17:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@maciaszczykm maciaszczykm changed the title feat: Update pipelines model feat: Update pipelines controller Jan 5, 2024
@maciaszczykm maciaszczykm self-assigned this Jan 5, 2024
@maciaszczykm maciaszczykm added the enhancement New feature or request label Jan 8, 2024
@maciaszczykm maciaszczykm marked this pull request as ready for review January 8, 2024 13:49
@maciaszczykm
Copy link
Member Author

It can be reviewed ang merged already, the pipeline reconciler is not registered yet.

@maciaszczykm maciaszczykm marked this pull request as draft January 8, 2024 15:08
@maciaszczykm
Copy link
Member Author

Registered pipeline reconciler, so marking is as draft for now.

@maciaszczykm maciaszczykm marked this pull request as ready for review January 9, 2024 12:38
michaeljguarino
michaeljguarino approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maciaszczykm
Copy link
Member Author

maciaszczykm commented Jan 10, 2024 •
edited
Loading

Unit tests and lint are failing on master CI. Locally tests pass. We'll have to fix them from there.

@maciaszczykm maciaszczykm merged commit afc1215 into master Jan 10, 2024
11 of 14 checks passed
@maciaszczykm maciaszczykm deleted the pipelines-model branch January 10, 2024 09:29
snikch pushed a commit to snikch/plural-console that referenced this pull request Apr 17, 2024
@maciaszczykm @snikch
feat: Update pipelines controller (pluralsh#589)
1502d47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zreigz zreigz zreigz approved these changes

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees

@maciaszczykm maciaszczykm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciaszczykm @michaeljguarino @zreigz