Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cd install check cluster #471

Merged
merged 3 commits into from
Nov 14, 2023
Merged

feat: cd install check cluster #471

merged 3 commits into from
Nov 14, 2023

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Nov 13, 2023

Summary

Check if the url and token are valid for the cluster

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz changed the title cd install check cluster feat: cd install check cluster Nov 13, 2023
@zreigz zreigz added the enhancement New feature or request label Nov 13, 2023
michaeljguarino
michaeljguarino reviewed Nov 13, 2023
View reviewed changes
cmd/plural/cd.go Outdated Show resolved Hide resolved
@zreigz zreigz merged commit 183eafb into main Nov 14, 2023
11 of 12 checks passed
@zreigz zreigz deleted the cd-check-cluster branch November 14, 2023 16:10
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
@zreigz @michaeljguarino
feat: cd install check cluster (#471)
32c5278 
* cd install check cluster

* add mocks

* display cluster details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

@davidspek davidspek Awaiting requested review from davidspek

Assignees

@michaeljguarino michaeljguarino

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @michaeljguarino