Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Increase cmake minimum version #1213

Open
karczex opened this issue Oct 1, 2021 · 1 comment
Open

Increase cmake minimum version #1213

karczex opened this issue Oct 1, 2021 · 1 comment
Labels
Priority: 4 low Type: Feature New feature or request

Comments

@karczex
Copy link

karczex commented Oct 1, 2021

Increase cmake minimum version to cmake >= 3.18

Rationale

Since 3.18 Cmake supports REQUIRED parameter in find_program(), which would simplify cmake files in many places all over codebase.

instead of:

find_program(variable_name NAMES program_name)
if( NOT variable_name)
     message(FATAL_ERROR "program not found")
endif()

may be just:

find_program(variable_name NAMES program_name REQUIRED)
@karczex karczex added Type: Feature New feature or request Priority: 4 low labels Oct 1, 2021
@KFilipek
Copy link
Contributor

KFilipek commented Oct 1, 2021

Hm, can we set "property" in easy way or rewrite it?

# Configure the ccache as compiler launcher
find_program(CCACHE_FOUND ccache)
if(USE_CCACHE AND CCACHE_FOUND)
	set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
endif()

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: 4 low Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants