-
Notifications
You must be signed in to change notification settings - Fork 13
[tests] add async cases for timestamp test #274
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @KFilipek)
a discussion (no related file):
please rebase with the latest master
tests/unittest/timestamp.cpp
line 4 at r1 (raw file):
/* Copyright 2022, Intel Corporation */ #include <random>
do we need this?
5ab1115
to
23e290a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @KFilipek and @lukaszstolarczuk)
a discussion (no related file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
please rebase with the latest master
Done.
tests/unittest/timestamp.cpp
line 4 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
do we need this?
Line 28: there is Mersenne twister for std::shuffle()
function.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KFilipek)
For this PR to be merged we'd have to fix the reported issue. |
Added asynchronous cases for timestamp test.
Issues related:
Resolves #275
Resolves #211
This change is