Integrate codecov.io #11
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
======================================
Coverage ? 75%
======================================
Files ? 10
Lines ? 172
Branches ? 21
======================================
Hits ? 129
Misses ? 29
Partials ? 14
Continue to review full report at Codecov.
|
utils/docker/run-coverage.sh
Outdated
| cd $WORKDIR | ||
| if [ -n "$COMPILER" ]; then | ||
| export CC=$COMPILER | ||
| fi |
utils/docker/run-coverage.sh
Outdated
| export CC=$COMPILER | ||
| fi | ||
|
|
||
|
|
There was a problem hiding this comment.
Too many empty lines.
|
Review status: 0 of 10 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
|
Reviewed 6 of 10 files at r1, 4 of 4 files at r2. Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
|
Reviewed 6 of 10 files at r1, 4 of 4 files at r2. Comments from Reviewable |
|
Closing because of merge issues. I did the merge and submitted a new pull request since I don't have permissions to GBuella's repo. |
This test would fail while using skip ranges (removed
in the previous commmit), with the following result:
```
$ cf -R asm_pattern_pattern_symbol_boundary3
Test project /home/tej/code/syscall_intercept/build
Start 11: asm_pattern_pattern_symbol_boundary3
1/1 Test pmem#11: asm_pattern_pattern_symbol_boundary3 ...***Failed 0.00 sec
Invalid patch
patch vs. expected:
0x0000: 0x48 0x48
0x0001: 0x31 0x31
0x0002: 0xc0 0xc0
0x0003: 0x48 0x48
0x0004: 0xc7 0xc7
0x0005: 0xc0 0xc0
0x0006: 0x01 0x01
0x0007: 0x00 0x00
0x0008: 0x00 0x00
0x0009: 0x00 0x00
0x000a: 0x90 0x90
0x000b: 0x48 0x48
0x000c: 0xf7 0xf7
0x000d: 0xd0 0xd0
0x000e: 0xeb 0xeb
0x000f: 0x0c 0x0c
0x0010: 0x48 0x48
0x0011: 0x83 0x83
0x0012: 0xf8 0xf8
0x0013: 0xff 0xff
0x0014: 0x48 0x48
0x0015: 0xc7 0xc7
0x0016: 0xc0 0xc0
0x0017: 0x02 0x02
0x0018: 0x00 0x00
0x0019: 0x00 0x00
0x001a: 0x00 0x00
0x001b: 0xe9 0x90 <-
0x001c: 0xe5 0xe9 <-
0x001d: 0x0c 0xe4 <-
0x001e: 0x20 0x0c <-
0x001f: 0x00 0x20 <-
0x0020: 0xcc 0x00 <-
0x0021: 0x48 0x48
0x0022: 0xff 0xff
0x0023: 0xc0 0xc0
0% tests passed, 1 tests failed out of 1
Total Test time (real) = 0.01 sec
The following tests FAILED:
11 - asm_pattern_pattern_symbol_boundary3 (Failed)
Errors while running CTest
```
The dummy symbol pattern_symbol_boundary3.in.s contains no
syscall instruction, therefore it would be skipped during
disassembly.
This resolves pmem#11
Ref: #7
This change is