set INTERCEPT_ALL_OBJS in tests when needed #28
Conversation
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
With this patch, and the one in pmem/pmdk#2063 (which I'll bring downstream from NVML after being merged there) I managed to successfully execute all tests with clang and ASAN. Ref #7 |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 56.93% 56.93%
=======================================
Files 18 18
Lines 1486 1486
Branches 413 413
=======================================
Hits 846 846
Misses 440 440
Partials 200 200Continue to review full report at Codecov.
|
|
Update: I added another commit, for setting another variable. |
GBuella
force-pushed
the
test_env_set
branch
2 times, most recently
from
20ec50b to
6b3fe86
Compare
|
Reviewed 4 of 4 files at r3. Comments from Reviewable |
test/check_log.cmake
Outdated
| execute_process(COMMAND ${TEST_PROG} | ||
| ${TEST_PROG_ARG} ${LOG_OUTPUT} ${SECOND_LOG_OUTPUT} | ||
| RESULT_VARIABLE HAD_ERROR) | ||
| unset(ENV{LD_PRELOAD}) | ||
| unset(ENV{LD_DEBUG}) |
There was a problem hiding this comment.
Is this supposed to be here?
There was a problem hiding this comment.
Nope, I just forgot it.
test/check_log.cmake
Outdated
| execute_process(COMMAND ${TEST_PROG} ${TEST_PROG_ARG} ${LOG_OUTPUT} | ||
| RESULT_VARIABLE HAD_ERROR) | ||
| unset(ENV{LD_PRELOAD}) | ||
| unset(ENV{LD_DEBUG}) |
This allows testing build with the -fsanitize=address flag. The INTERCEPT_ALL_OBJS is not needed during asm_pattern tests, is needed during logging tests (as some log messages might pass through syscall instructions in asan object code outside libc), and are not needed during the prog_* tests - as those tests only look at a specific syscall made in the app anyways.
For preload asan runtime when needed.
|
Reviewed 3 of 4 files at r3, 1 of 1 files at r4. Comments from Reviewable |
|
Reviewed 3 of 4 files at r3, 1 of 1 files at r4. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
This allows testing build with the -fsanitize=address flag.
The INTERCEPT_ALL_OBJS is not needed during asm_pattern tests,
is needed during logging tests (as some log messages might pass
through syscall instructions in asan object code outside libc),
and are not needed during the prog_* tests - as those tests
only look at a specific syscall made in the app anyways.
This change is