Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XTBWrapper does not have attribute .xyz #14

Open
jessbade opened this issue Sep 12, 2023 · 2 comments
Open

XTBWrapper does not have attribute .xyz #14

jessbade opened this issue Sep 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jessbade
Copy link
Collaborator

In the case of running isicle.md.XTBWrapper() to optimize structures then passing this geom to isicle.mdXTBWrapper() to generate conformers, an uncaught error occurs.

  • isicle.md.XTBWrapper.set_geometry() sets an isicle.md.XTBWrapper to self.geom
  • then isicle.md.XTBWrapper.save_geometry() is executed inside set_geometry()
  • save_geometry() calls isicle.io.save(<filename.xyz>,<isicle.md.XTBWrapper>), which calls isicle.io.save_xyz() since filetype is .xyz
  • isicle.io.save_xyz checks: if not isinstance(geom, (isicle.geometry.Geometry, isicle.geometry.XYZGeometry)) then raise TypeError
  • isicle.md.XTBWrapper is sub-class of isicle.geometry.XYZGeometry and therefore passes check
  • error at isicle.io.save_xyz, line 508 since isicle.md.XTBWrapper object does not have .xyz attribute

min. ex:
geom=isicle.load('CCO')
geom = geom.initial_optimize(embed=True, forcefield="UFF", ff_iter=200)
opts=geom.md(task='optimize')
confs=opts.md(task='conformers')

@jessbade jessbade added the bug Something isn't working label Sep 12, 2023
@smcolby
Copy link
Collaborator

smcolby commented Sep 12, 2023

XTBWrapper should not inherit XYZGeometry or Geometry.

@smcolby
Copy link
Collaborator

smcolby commented Sep 12, 2023

NWChemWrapper also does this, and should not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants