Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepONet Example #168

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

DeepONet Example #168

wants to merge 17 commits into from

Conversation

colbyham
Copy link
Collaborator

First DeepONet example, wrapping up modifications in this new branch after messy rebase

@RBirmiwal
Copy link
Collaborator

This is looking good so far!

Copy link
Contributor

@drgona drgona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new DeepONet class abstraction

  • lets add explanation in the docstring on problem dimensions: Nu, Nsamples, in_size_trunk, interact_size
  • Lets try to make the example more didactical. We should add a paragraph explaining DeepONet architecture including figure from the paper.
  • we need to add more markdown in the code - each cell should have a brief markdown explanation
  • lets avoid the use of undefined acronyms - for instance, its not clear what is 1d grf from deepxde - moreover as far as I can tell these features are not used further in the code - each cell needs to be intentional. We should avoid junk code in the example
  • lets avoid cells that generate more than single figure
  • IMPORTANT: current example will not run - it expects training data from examples/neural_operators/datasets - Lets generate data by simulating the system not by loading from any file
  • I don't see the utility of cell with scipy integrate and associated plot
  • I don't see the need for changes in Trainer and Problem classes currently suggested

@colbyham
Copy link
Collaborator Author

colbyham commented Jul 1, 2024

Will briefly respond to the comments before our meeting tomorrow. The "1d grf from deepxde" is part of me trying to get the data generation working in the example and that is also the reason why multiple plots are being show for my debugging purposes. I talked to @brunopjacob and think I have a way forward for data generation. The extra changes from Trainer and Problem are accidental from code reformat. I will pull a fresh copy and only put the changes necessary Trainer ( loss history), Problem (predict)

@colbyham colbyham marked this pull request as draft July 1, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants