This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Fixed incorrect implementation of content type id best match #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Previous implementation of content type id BestMatch was incorrect. It did not check for a common parent and could therefore end up with not finding av best match even though a content type sharing the same parent existed. For example if an Item list content type on a list with id 0x010100C284F907FFBF7D45B2B102E254551281 and an Item list content type on a different list with id 0x010100CE36B052C59F4C46ADD8ADA2F8668F3D the previous implementation would not find any match. It should identify 0x010100CE36B052C59F4C46ADD8ADA2F8668F3D as the best match for 0x010100C284F907FFBF7D45B2B102E254551281.
Implementation of BestMatch in this PR has been taken from the server side implementation of the same functionality.