Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature]: Improve re-login experience #342

Open
Adam-it opened this issue Nov 13, 2024 · 0 comments
Open

💡 [Feature]: Improve re-login experience #342

Adam-it opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Nov 13, 2024

🎯 Aim of the feature

I noticed that SPFx toolkit has a glitch that even though the status command returns that I am logged in, the first command to get the app catalogs from my tenant requires me to sign in which is only visible in the output window. This leads to a state were I am not logged in, I don't see anything in the account and app catalog view, but I also don't see the sign-in button. We should fix it up.

From what i checked the token expired and I need to resign to refresh it. This is fine but:

  • first is the above described problem, I don't see the sign it or out button, I need to 'manually' sign out using the command palette in VS Code and then I am able to relogin
  • when signing out we clear out the client Id and tenant Id. Usually I don't remember those so I just create an another entra app reg. I must have like 40 SPFx Toolkit apps by now on my tenant 😅. What we could do is 'cache' the client and tenant Id so that when next time we relogin and we pick to sign in using the existing client Id and tenant Id we have those fields prefilled with the previous values (when we previously sign in). VS Code has a mechanism for that to preserve state between multiple sessions of VS Code and we could use that.

📷 Images (if possible) with expected result

No response

🤔 Additional remarks or comments

No response

@Adam-it Adam-it added ⭐ enhancement New feature or request 🤔 research needs researching before I start hacking labels Nov 13, 2024
@Adam-it Adam-it self-assigned this Nov 13, 2024
@Adam-it Adam-it added ✏️prototype and removed 🤔 research needs researching before I start hacking labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant