IsValid returns false for valid value (4.0.0)

[autori-toni]

I've run into problem where seemingly valid index created with FromPoint-method is deemed invalid by the IsValid.

var point = new Point(24.57011413572222, 60.191627502416665) { SRID = 4326 };
var h3Index = H3Index.FromPoint(point, 15);
var index = h3Index.IsValid; // => false

The problem exists only on version 4.0.0, same point is returned as "valid" index by the previous version 3.7.2.1.

The validation seems to fail at last line where leading zeros are checked.

[pocketken]

I've run into problem where seemingly valid index created with FromPoint-method is deemed invalid by the IsValid.

var point = new Point(24.57011413572222, 60.191627502416665) { SRID = 4326 };
var h3Index = H3Index.FromPoint(point, 15);
var index = h3Index.IsValid; // => false

The problem exists only on version 4.0.0, same point is returned as "valid" index by the previous version 3.7.2.1.

The validation seems to fail at last line where leading zeros are checked.

First off apologies for the late reply, notifications in GH were not working for some reason.

Are you using anything prior to dotnet 5? There's a bug in the LeadingNonZero method in the "polyfilled" versions I had in place for this release; it should be fixed in the next one once I finally get a few minutes to spend a bit of time catching up on this project. If you want you can try checking out the dev/km/rel-4.1.0 branch and let me know if you can still reproduce the issue.

I'll add this as a test case anyway just in case.

[pocketken]

Nope; still a bug in the latest stuff. Will take a look.

[jrgcubano]

@pocketken Hello. Were you able to fix the bug? I was upgrading our projects to NET8 and was going to upgrade this library.
​

[pocketken]

Hi @jrgcubano, unfortunately not yet. I just haven't had any free time recently, so I only got as far as some basic debugging. I'm not quite sure when I will be able to look at it, as it seems like as soon as one work project ends 3 more start. I am happy to accept PRs, though!