-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine engine_options
and read_options
into a single parameter in read_excel
#17265
Comments
I'm pretty sure @alexander-beedie already has a design for this (see #15808 (comment)). Not sure it will make it into 1.0.0 though. |
I do, and it's "mostly" option 3, where the most common options are all exposed at the top-level and we convert them to engine-specific calls ourselves so the user doesn't have to (as we're now doing with We will still maintain |
Thanks; should I go ahead and close this one? |
It's ok, can leave it here so I have something to focus on and close when it's done (hopefully very shortly) 🤣 |
FYI: #17263 now contains a common |
...and just added a common |
I'd like to comment on the suggestion for |
Description
Somewhat related to #17263.
read_excel
has two parameters,engine_options
andread_options
:engine_options
- Additional options passed to the underlying engine’s primary parsing constructor (given below), if supportedread_options
- Options passed to the underlying engine method that reads the sheet dataThis is really confusing from a user perspective. What's the difference between engine options that parse the data and engine options that reads the data? IMO, it would be easier to provide a universal set of options that are converted to the engine-specific options behind the scenes. All engines provide the same functionality for reading at this point, so it would be nice to instead have the following parameters (feel free to add):
sheet_name
- specifies sheet by namesheet_id
- specifies sheet by ID, 1-indexed. If 0, return all sheets as a dict.range
- e.g.B3:AC52
or something like[(2,5), (83, 15)]
(already available as "schema_overrides")dtypes
- dtypes of columnsThe text was updated successfully, but these errors were encountered: