Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the option to overwrite field names to be responsibility of the new_columns parameter #18864

Open
vmgustavo opened this issue Sep 23, 2024 · 0 comments
Open

Move the option to overwrite field names to be responsibility of the new_columns parameter #18864

vmgustavo opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or an improvement of an existing feature

Comments

@vmgustavo
Copy link

Description

From an issue I thought to be a bug but it is actually expected behavior:

This is expected behavior, as the schema argument allows you to overwrite field names. You provide the schema and the fields of the file will be ignored.

Originally posted by @ritchie46 in #18821 (comment)

Shouldn't the ability to overwrite field names happen only when new_columns param is specified?
@vmgustavo vmgustavo added the enhancement New feature or an improvement of an existing feature label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vmgustavo