Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reshape + .arr.to_struct() capacity overflow PanicException #18879

Closed
2 tasks done
cmdlineluser opened this issue Sep 24, 2024 · 0 comments · Fixed by #18923
Closed
2 tasks done

reshape + .arr.to_struct() capacity overflow PanicException #18879

cmdlineluser opened this issue Sep 24, 2024 · 0 comments · Fixed by #18923
Assignees
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl

df = pl.DataFrame({"foo": [[[1, 2], [3, 4]]]})
df.select(pl.col.foo.list.explode().reshape((2, -1)).arr.to_struct())

# thread '<unnamed>' panicked at alloc/src/raw_vec.rs:24:5:
# capacity overflow
# PanicException: capacity overflow

Log output

No response

Issue description

It works if we introduce a new select context.

(df.select(pl.col.foo.list.explode().reshape((2, -1)))  
   .select(pl.all().arr.to_struct())
)

# shape: (2, 1)
# ┌───────────┐
# │ foo       │
# │ ---       │
# │ struct[2] │
# ╞═══════════╡
# │ {1,2}     │
# │ {3,4}     │
# └───────────┘

Expected behavior

No panic.

Installed versions

--------Version info---------
Polars:               1.8.1
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
great_tables:         <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
sqlalchemy:           <not installed>
torch:                <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Sep 24, 2024
@coastalwhite coastalwhite self-assigned this Sep 25, 2024
coastalwhite added a commit to coastalwhite/polars that referenced this issue Sep 25, 2024
This fixes the `reshape` function to properly infer dimensions in the schema.

I did this by adding a "zero-cost" `ReshapeDimension` enum that can either be
`Specified(u64)` or `Infer`. This also makes the reshaping behavior more
consistent as now all negative values are always assumed to be `Infer`.

During this work, I saw an unneeded allocation in `reshape_array` and removed
it.

Fixes pola-rs#18879.
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants