Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python, rust!): Rename .list.lengths and .str.lengths #11613

Merged
merged 10 commits into from
Oct 10, 2023
Merged

depr(python, rust!): Rename .list.lengths and .str.lengths #11613

merged 10 commits into from
Oct 10, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Oct 9, 2023 •
edited
Loading

Closes #11577

Changes

  • Rename .list.lengths to .list.len
  • Rename .str.lengths to .str.len_bytes
  • Rename .str.n_chars to .str.len_chars

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars labels Oct 9, 2023
@stinodego stinodego marked this pull request as ready for review October 9, 2023 12:07
@eitsupi

This comment was marked as off-topic.

Sign in to view
@stinodego

This comment was marked as off-topic.

Sign in to view
alexander-beedie
alexander-beedie approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python side looking good to me; a welcome consolidation/clarification! ✌️

@stinodego stinodego merged commit f23f2c3 into main Oct 10, 2023
28 checks passed
@stinodego stinodego deleted the lengths branch October 10, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@alexander-beedie alexander-beedie alexander-beedie approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename .list.lengths and .str.lengths
4 participants
@stinodego @eitsupi @alexander-beedie @ritchie46