Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(python): Deprecate default value for radix in parse_int #11615

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Oct 9, 2023

The default value of 2 does not make much sense here. This PR deprecates the default value.

@orlp FYI

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Oct 9, 2023
@stinodego stinodego force-pushed the parse-int-default-radix branch 2 times, most recently from 63f091c to 5b39438 Compare October 9, 2023 12:31
@stinodego stinodego marked this pull request as ready for review October 9, 2023 12:34
@stinodego stinodego force-pushed the parse-int-default-radix branch from 5b39438 to fe590df Compare October 9, 2023 12:48
@stinodego stinodego requested a review from orlp October 9, 2023 13:18
@stinodego stinodego merged commit c884a03 into main Oct 9, 2023
12 checks passed
@stinodego stinodego deleted the parse-int-default-radix branch October 9, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant