-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(python): Disable clippy lint "too many arguments" for py-polars
#11616
chore(python): Disable clippy lint "too many arguments" for py-polars
#11616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to disable this for py-polars
, as we don't really choose the number of arguments - it's dictated by the Python side, and having many arguments isn't that much of a problem due to default values.
I wouldn't support turning this off for the Rust code base. We should probably take a look at these functions and refactor them, instead of turning off the lints globally.
Well, when I encounter some daunting task like this, especially if it's sprinkled just about everywhere in the code, I tend to disable the warnings. |
py-polars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disabled the lint properly in lib.rs
. This is good to go!
Removing all the arguments that are across the code by lifting the threshold to 99.