fix: return float dtype in interpolate (for method="linear") for numeric dtypes #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ear") for numeric dtypes
MarcoGorelli
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
|
Can you remove EDIT: on closer inspection, it now seems that the date types involve two casts to/from floating point? Shouldn't those be done entirely in integer land then? Perhaps the unsigned variant is still needed then. |
|
thanks for your review! yes, good point
The physical dtype would still be signed, so I think you're right that it wouldn't be needed |
stinodego
changed the title
github-actions
bot
added
breaking
ritchie46
approved these changes
Oct 13, 2023
stinodego
changed the title
stinodego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part I of addressing #11595
Not changing anything to do with
method='nearest'in this oneFor numeric types, I'm making it return float - but for temporal types, I'm preserving the current functionality of preserving the data type. It could return a high-resolution datetime instead, but it'd be backed by integers anyway so I'm not totally sure about whether that's a good idea