refactor: improve rank implementation, especially around nulls #11651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
internal
ritchie46
reviewed
Oct 11, 2023
| @@ -42,8 +43,29 @@ fn get_random_seed() -> u64 { | |||
| rng.next_u64() | |||
| } | |||
|
|
|||
| unsafe fn rank_impl<F: FnMut(&mut [IdxSize])>(idxs: &IdxCa, neq: &BooleanArray, mut flush_ties: F) { | |||
| let mut ties_indices = Vec::with_capacity(128); | |||
| let mut idx_it = idxs.downcast_iter().flat_map(|arr| arr.values_iter()); | |||
There was a problem hiding this comment.
Can we use a double loop here, so the iteration is slightly faster?
There was a problem hiding this comment.
I think this compiles down to a double loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11252.