Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): LazyFrame._with_fast_projection() #11920

Closed
wants to merge 2 commits into from

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Oct 21, 2023

From pola-rs/r-polars#439

Add the function that changes fast_projection because it didn't seem to exist.
(Since it is not added to Python here, please add it to Python if necessary.)

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Oct 21, 2023
@eitsupi eitsupi force-pushed the with_fast_projection branch from c63db0e to cce21b8 Compare October 21, 2023 11:03
@eitsupi eitsupi changed the title feat(rust): LazyFrame.with_fast_projection() feat(rust): LazyFrame._with_fast_projection() Oct 21, 2023
@ritchie46
Copy link
Member

This is more something for the optimizer, not really meant to be exposed.

@eitsupi
Copy link
Contributor Author

eitsupi commented Nov 2, 2023

Thanks for your reply.
But it seems strange that there is no function to change just one member of OptState.

pub struct OptState {
pub projection_pushdown: bool,
pub predicate_pushdown: bool,
pub type_coercion: bool,
pub simplify_expr: bool,
pub file_caching: bool,
pub slice_pushdown: bool,
#[cfg(feature = "cse")]
pub comm_subplan_elim: bool,
#[cfg(feature = "cse")]
pub comm_subexpr_elim: bool,
pub streaming: bool,
pub eager: bool,
pub fast_projection: bool,
}

@stinodego
Copy link
Member

Closing this as Ritchie has remarked this property should not be set directly.

@stinodego stinodego closed this Jan 15, 2024
@eitsupi eitsupi deleted the with_fast_projection branch January 15, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants