-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python, rust): add mean_horizontal expression #11937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @romanovacca, looks good. Small remark about the names.
76c5c7c
to
cf1e4e8
Compare
Thank you @romanovacca. Can you rebase? Then it is good to go. |
b99fe01
to
dd88edb
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here. Thanks @romanovacca
Whoops, we need another rebase. :') |
@ritchie46 sorry for the delay. I don't think this is relevant anymore after #12492, right? One thing I do still see is that that PR still uses the ".map(|opt_s| opt_s.map(|s| s.with_name("max")))" format, which automatically creates a column with the name, whereas iirc you mentioned you want it to take on the lefthand column name and thus leave that part out. I can do that in a new PR if you want to? |
We still don't have a |
Hey @romanovacca I was trying to add this but just noticed you have already implemented it. From what I can tell, all that needs to change here is that (And the edits to |
Superseded by #14369 |
as discussed in #9966, implemented
mean_horizontal
.If this is the way to go, I will create separate PR's for others.