Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add FileNotFoundError #11976

Closed

Conversation

romanovacca
Copy link
Contributor

@romanovacca romanovacca commented Oct 24, 2023

Closes #10640

Currently when reading a non existing file with scan_csv, you get the following error:

exceptions.ComputeError: error open file: example.csv, error open file: example.csv, No such file or directory (os error 2)

Where the error message is also duplicated because of how the error is passed.

After this PR, it looks like:

polars.exceptions.FileNotFoundError: No such file or directory: example.csv

Not sure if the way i have implemented it, is what you meant in the issue @stinodego ? With the way I have set it up now, we could also check for other reading errors such as "Permission Denied" etc, but not sure if you see added value to that.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 24, 2023
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost what I meant! See my comment to raise the correct error in Python.

py-polars/src/error.rs Outdated Show resolved Hide resolved
@stinodego stinodego changed the title feat(rust, python): add FileNotFoundError feat: Add FileNotFoundError Oct 24, 2023
py-polars/src/lib.rs Outdated Show resolved Hide resolved
py-polars/src/error.rs Outdated Show resolved Hide resolved
@stinodego stinodego force-pushed the #10640_add_FileNotFoundError branch from 0768367 to 11ed15a Compare November 10, 2023 00:06
@stinodego
Copy link
Member

After looking at this a bit more, we have to do things a bit differently. I opened #12355 as a replacement for this one, inspired by the work in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise FileNotFoundError instead of ComputeError on missing csv file
3 participants