-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add FileNotFoundError
#11976
Closed
romanovacca
wants to merge
10
commits into
pola-rs:main
from
romanovacca:#10640_add_FileNotFoundError
Closed
feat: Add FileNotFoundError
#11976
romanovacca
wants to merge
10
commits into
pola-rs:main
from
romanovacca:#10640_add_FileNotFoundError
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovacca
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
October 24, 2023 12:12
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
labels
Oct 24, 2023
reswqa
reviewed
Oct 24, 2023
stinodego
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost what I meant! See my comment to raise the correct error in Python.
stinodego
changed the title
feat(rust, python): add FileNotFoundError
feat: Add Oct 24, 2023
FileNotFoundError
stinodego
reviewed
Oct 25, 2023
stinodego
reviewed
Oct 25, 2023
stinodego
reviewed
Oct 25, 2023
stinodego
force-pushed
the
#10640_add_FileNotFoundError
branch
from
November 10, 2023 00:06
0768367
to
11ed15a
Compare
After looking at this a bit more, we have to do things a bit differently. I opened #12355 as a replacement for this one, inspired by the work in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10640
Currently when reading a non existing file with
scan_csv
, you get the following error:Where the error message is also duplicated because of how the error is passed.
After this PR, it looks like:
Not sure if the way i have implemented it, is what you meant in the issue @stinodego ? With the way I have set it up now, we could also check for other reading errors such as "Permission Denied" etc, but not sure if you see added value to that.