feat: Expressify n of shift #12004
Merged
feat: Expressify n of shift #12004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
reswqa
commented
Oct 25, 2023
| @@ -416,6 +416,60 @@ impl OptimizationRule for TypeCoercionRule { | |||
| options, | |||
| }) | |||
| }, | |||
| // shift and fill should only cast left and fill value to super type. | |||
| AExpr::Function { | |||
| function: FunctionExpr::ShiftAndFill, | |||
There was a problem hiding this comment.
This function is special as only partial inputs(left and fill_value) should cast to super type. I'm not sure, but as we continue to expressify arguments, this requirement will become more and more common, and we may need to add support for casting partial inputs in the future. 🤔
There was a problem hiding this comment.
Yes, good point. I feel that that should be an option of the FunctionOptions.
There was a problem hiding this comment.
Yes, maybe change the type of cast_to_super_type to Optional<Vec>, WDYT?
reswqa
requested review from
ritchie46,
c-peters,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.