fix: fix apply_to_inner's dtype #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
force-pushed
the
repeat_by_type
branch
from
126d383 to
57dba94
Compare
reswqa
force-pushed
the
repeat_by_type
branch
from
57dba94 to
a7a07de
Compare
reswqa
commented
Oct 25, 2023
|
|
||
| let inner_dtype = LargeListArray::default_datatype(out.dtype().to_arrow()); | ||
| let arr = LargeListArray::new( | ||
| inner_dtype, |
There was a problem hiding this comment.
This inner_dtype seems should be the dtype of backed values instead of out(maybe logical).
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11978.