fix(python,rust!): Fix scan_csv error type
#12355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
removed
the
enhancement
stinodego
changed the title
scan_csv error typescan_csv error type
github-actions
bot
added
the
breaking rust
stinodego
requested review from
ritchie46,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
ritchie46
requested changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10640
Inspired by @romanovacca 's work in #11976
Changes
open_fileutil from polars-utils (there were 3 competing implementations)open_fileutil to raise a Polars IO error rather than a ComputeError.FileNotFoundError.Remove truncation of the path to 88 characters. Paths may be long sometimes, but I am definitely interested in the full path if it turns out there is an error.