docs(python): bring sink_ndjson docstring in line with other sink docstrings #13636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryharbeck
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
github-actions
bot
added
documentation
stinodego
approved these changes
Jan 11, 2024
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
…strings (pola-rs#13636) Co-authored-by: Henry Harbeck <henry.harbeck@canstar.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11644 the docstrings for
sinkmethods were updated fromto
Also, all other sink methods have the
slice_pushdownparameter second last and theno_optimizationparameter last.This brings
sink_ndjsonin line with both of those.PS: sorry for the tiny PR - hopefully not too spammy