-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python,rust!): Infer values
columns in DataFrame.pivot
when values
is None
#14477
Conversation
values
parameter in pl.pivot
optionalvalues
parameter in DataFrame.pivot
optional
values
parameter in DataFrame.pivot
optionalvalues
parameter in DataFrame.pivot
optional
values
parameter in DataFrame.pivot
optionalvalues
parameter in DataFrame.pivot
optional
Yes, this is breaking. You can remove the deprecation decorator from the method too. |
values
parameter in DataFrame.pivot
optionalvalues
parameter in DataFrame.pivot
optional
c5f676c
to
38b8f25
Compare
8549348
to
412e79e
Compare
412e79e
to
9c8da34
Compare
@stinodego got a Chocolatey CI error here, should keep an eye open to see if it pops up elsewhere. |
This is a known issue - I reported it here: ts-graphviz/setup-graphviz#557 |
@stinodego I think we should revert the set usage, unless you can think of a better way out. The order of the output columns in |
Ah, I hadn't considered that. Let's revert it then 👍 |
I have a way to both use the faster sets path and preserve column order. |
9d63ac5
to
a5e73c6
Compare
values
parameter in DataFrame.pivot
optionalvalues
parameter in DataFrame.pivot
optional
a5e73c6
to
6c96b61
Compare
6c96b61
to
53e5293
Compare
I don't think it's worth allocating a new set here. Let's just go with the initial logic which was simplest. We can further optimize this later if required. I made the update and this is now good to merge 👍 |
Thanks for the help @stinodego! |
values
parameter in DataFrame.pivot
optionalvalues
columns in DataFrame.pivot
when values
is None
Resolves #12087.
I think we hold off until the next breaking release.