Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): separate Aggregation evaluation PhysicalExpr from conversion #16688

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

coastalwhite
Copy link
Collaborator

This PR separates the evaluation of the AggregationExpr PhysicalExpr to its own method. In the way, I removed several no-longer-used fields and parameters.

@coastalwhite coastalwhite self-assigned this Jun 3, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jun 3, 2024
@coastalwhite coastalwhite changed the title refactor(rust): separate Agg evaluate PhysicalExpr refactor(rust): separate Aggregation evaluation PhysicalExpr from conversion Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 96.73203% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.46%. Comparing base (15981d7) to head (6832925).
Report is 14 commits behind head on main.

Files Patch % Lines
crates/polars-expr/src/expressions/aggregation.rs 96.66% 4 Missing ⚠️
crates/polars-expr/src/planner.rs 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16688      +/-   ##
==========================================
- Coverage   81.47%   81.46%   -0.01%     
==========================================
  Files        1416     1416              
  Lines      186884   186843      -41     
  Branches     3021     3023       +2     
==========================================
- Hits       152257   152208      -49     
- Misses      34094    34103       +9     
+ Partials      533      532       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6a07565 into pola-rs:main Jun 4, 2024
21 checks passed
@coastalwhite coastalwhite deleted the plan-aggregations branch June 4, 2024 10:58
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants