Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix deprecated call to Array.width in assertion util #16707

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 4, 2024

Minor issue with #16700 which I didn't cover in unit tests (sorry). Testing it uncovered another bug, so it's still not covered, but at least it should be fixed.

@stinodego stinodego added the skip changelog Do not include in changelog label Jun 4, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jun 4, 2024
@stinodego stinodego marked this pull request as ready for review June 4, 2024 07:52
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (4ef4aa4) to head (c3325d1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16707      +/-   ##
==========================================
- Coverage   81.49%   81.48%   -0.01%     
==========================================
  Files        1416     1416              
  Lines      186937   186880      -57     
  Branches     3026     3023       -3     
==========================================
- Hits       152337   152287      -50     
+ Misses      34068    34062       -6     
+ Partials      532      531       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 3a825c2 into main Jun 4, 2024
17 checks passed
@stinodego stinodego deleted the fix-depr branch June 4, 2024 08:08
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars skip changelog Do not include in changelog
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants