-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SQL support for NULLS FIRST/LAST
ordering
#16711
Conversation
5cfd5ad
to
aa59b85
Compare
aa59b85
to
2b0927c
Compare
NULLS FIRST/LAST
ordering directivesNULLS FIRST/LAST
ordering
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16711 +/- ##
==========================================
- Coverage 81.45% 81.43% -0.02%
==========================================
Files 1413 1413
Lines 186187 186188 +1
Branches 2776 2776
==========================================
- Hits 151655 151623 -32
- Misses 34012 34045 +33
Partials 520 520 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't code I'd looked at before, but the logic looks very simple (and, as far as I can tell, correct)
Nitpick but it looks like now def foods_ipc_path
happens in two places? Not an issue (and personally I'd prefer it this way, rather than having it magically happen in a conftest.py
), just pointing it out
63c0036
to
31f6751
Compare
CodSpeed Performance ReportMerging #16711 will not alter performanceComparing Summary
|
31f6751
to
efaa4fc
Compare
efaa4fc
to
1ba22f1
Compare
Updated/rebased (yet again :)) |
Builds on #16639, integrating the new capability (per-column nulls first/last) as SQL.
Examples