chore(rust!): move offset_by implementation from polars-plan to polars-time, rename feature from DateOffset to OffsetBy #16796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing a comment from a previous pr #16728 (comment)
I've also:
FunctionExpr::DateOffset
toFunctionExpr::TemporalExpr(TemporalFunction::OffsetBy
date_offset
tooffset_by
I've noticed that whereas in
polars-ops
, every feature seems to be under its own feature flag, in polars-time that doesn't seem to be the case. I've putoffset_by
,month_start
, andmonth_end
under their own feature flags - is this ok?Functional changes: none