-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Add min periods for correlation (#15458) #16987
base: main
Are you sure you want to change the base?
feat(rust): Add min periods for correlation (#15458) #16987
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16987 +/- ##
==========================================
- Coverage 80.74% 80.73% -0.01%
==========================================
Files 1475 1475
Lines 193389 193427 +38
Branches 2760 2760
==========================================
+ Hits 156146 156164 +18
- Misses 36733 36753 +20
Partials 510 510 ☔ View full report in Codecov by Sentry. |
…/Add_min_periods_to_polars.corr_#15458
Thank you @fkemeth, I think this looks pretty good. However, we should not return |
…_periods_to_polars.corr_#15458
…b.com:fkemeth/polars into feature/Add_min_periods_to_polars.corr_#15458
@ritchie46 thank you for the comment! I updated the PR accordingly. The functions return I also updated the unit tests, which now check for
if min_periods is larger than the common overlap between the two vectors. Can you have a look? |
Add min_periods support to correlation (pearson, spearman and cov). See #15458.