fix(rust, python): Correctly convert data frames to NumPy for C index order #17000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#16288 introduced a regression that caused
to_numpy(order="c")
calls to silently yield erroneous NumPy arrays whenever the data frame has more than one chunk. To reproduce with the latest release or polarsmain
:Currently, this results in an assertion failure. This PR fixes the issue.
I'm not sure if this is easily feasible but it would be great if this change could be released prior to a v1 release as it is quite a nasty bug 👀