-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python)!: Rename ModuleUpgradeRequired
and PolarsPanicError
error, remove InvalidAssert
error
#17033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
Change that breaks backwards compatibility
internal
An internal refactor or improvement
python
Related to Python Polars
labels
Jun 17, 2024
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
June 17, 2024 22:48
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17033 +/- ##
==========================================
+ Coverage 80.95% 80.97% +0.01%
==========================================
Files 1448 1448
Lines 190554 190586 +32
Branches 2723 2723
==========================================
+ Hits 154265 154323 +58
+ Misses 35786 35759 -27
- Partials 503 504 +1 ☔ View full report in Codecov by Sentry. |
stinodego
changed the title
refactor(python)!: Remove
refactor(python)!: Rename Jun 18, 2024
InvalidAssert
error and rename ModuleUpgradeRequired
errorModuleUpgradeRequired
error and remove InvalidAssert
error
stinodego
changed the title
refactor(python)!: Rename
refactor(python)!: Rename Jun 18, 2024
ModuleUpgradeRequired
error and remove InvalidAssert
errorModuleUpgradeRequired
and PolarsPanicError
error, remove InvalidAssert
error
stinodego
changed the title
refactor(python)!: Rename
feat(python)!: Rename Jun 18, 2024
ModuleUpgradeRequired
and PolarsPanicError
error, remove InvalidAssert
errorModuleUpgradeRequired
and PolarsPanicError
error, remove InvalidAssert
error
github-actions
bot
added
the
enhancement
New feature or an improvement of an existing feature
label
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
breaking
Change that breaks backwards compatibility
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PolarsPanicError
toPanicException
. We are just re-exporting PyO3's PanicException, so the user seespyo3_runtime.PanicException: ...
. Re-exporting under a different name just causes confusion.ModuleUpgradeRequired
toModuleUpgradeRequiredError
. This is to satisfy naming conventions (errors should end inError
).InvalidAssert
error. It was used in 1 place (testing utils) and not really necessary. ATypeError
should suffice here.ComputeError
toInvalidOperationError
.PolarsError
andPolarsWarning
so that the display matches the name (previously would showPolarsBaseError
/PolarsBaseWarning
).I also considered removing the PanicException re-export altogether and making users write a bare
except:
, since panics are not really intended to be handled... open to feedback on this one.