build(python): Do not set environment variable on import #17101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17101 +/- ##
========================================
Coverage 80.86% 80.86%
========================================
Files 1456 1456
Lines 191141 191313 +172
Branches 2728 2737 +9
========================================
+ Hits 154562 154711 +149
- Misses 36073 36096 +23
Partials 506 506 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Jun 22, 2024
| std::env::var(env).unwrap_or_else(|_| { | ||
| panic!("env var: {env} must be set to allow extension types to be created",) | ||
| }); | ||
| if !(std::env::var(env).is_ok() || POLARS_ALLOW_EXTENSION.load(Ordering::Relaxed)) { |
There was a problem hiding this comment.
I think we should swap the order of these. Loading the static is likely cheaper and is what we always do in python Polars. Otherwise we must always evaluate the second branch.
|
1 comment. Other than that good. 👍 |
stinodego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16609
Not sure if this is an acceptable fix - feedback welcome.
I couldn't think of a good way to test this 🤔