Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add zip node to streaming engine #17866

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jul 25, 2024

No description provided.

@orlp orlp requested review from ritchie46 and c-peters as code owners July 25, 2024 12:28
@orlp orlp changed the title refactor(rust): add Zip node to streaming engine refactor(rust): Add Zip node to streaming engine Jul 25, 2024
@orlp orlp changed the title refactor(rust): Add Zip node to streaming engine refactor(rust): Add zip node to streaming engine Jul 25, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars and removed title needs formatting labels Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 165 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (9eec688) to head (cf81825).
Report is 22 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/nodes/zip.rs 0.00% 121 Missing ⚠️
crates/polars-stream/src/morsel.rs 0.00% 24 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_source.rs 0.00% 9 Missing ⚠️
crates/polars-stream/src/nodes/streaming_slice.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/nodes/select.rs 0.00% 2 Missing ⚠️
crates/polars-stream/src/nodes/reduce.rs 0.00% 1 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 1 Missing ⚠️
crates/polars-stream/src/physical_plan/to_graph.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17866      +/-   ##
==========================================
- Coverage   80.49%   80.42%   -0.07%     
==========================================
  Files        1503     1506       +3     
  Lines      197027   197428     +401     
  Branches     2795     2807      +12     
==========================================
+ Hits       158589   158791     +202     
- Misses      37918    38115     +197     
- Partials      520      522       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 54b7fb8 into pola-rs:main Jul 25, 2024
23 of 24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants