Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix simple projection in streaming engine #17871

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jul 25, 2024

No description provided.

@orlp orlp requested review from ritchie46 and c-peters as code owners July 25, 2024 14:34
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (3016c07) to head (3dd2468).

Files Patch % Lines
...rates/polars-stream/src/nodes/simple_projection.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17871      +/-   ##
==========================================
- Coverage   80.47%   80.47%   -0.01%     
==========================================
  Files        1505     1505              
  Lines      197273   197278       +5     
  Branches     2807     2807              
==========================================
- Hits       158764   158762       -2     
- Misses      37987    37994       +7     
  Partials      522      522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 5a108d4 into pola-rs:main Jul 25, 2024
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants