Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Fix rust-analyzer misinterpretation #20595

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 7, 2025

This gives a false-positive error, it thinks this is Ord::max for some reason.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (4eb8e48) to head (a0f81c4).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20595   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files        1564     1564           
  Lines      220882   220882           
  Branches     2510     2510           
=======================================
+ Hits       174399   174405    +6     
+ Misses      45908    45902    -6     
  Partials      575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 791dee5 into pola-rs:main Jan 7, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants