Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Ensure read_excel and read_ods support reading from raw bytes for all engines #20636

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 9, 2025

Closes #20630.
Closes #20526.

  • Fixes a minor calamine engine regression.
  • Adds missing bytes ingest support for openpyxl engine.
  • Specific test coverage for BytesIO, bytes, and memoryview across all engines.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jan 9, 2025
@alexander-beedie alexander-beedie added the A-io-spreadsheet Area: reading/writing Excel/ODS files label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (247f0b1) to head (78c5e82).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20636   +/-   ##
=======================================
  Coverage   79.03%   79.04%           
=======================================
  Files        1557     1557           
  Lines      220528   220534    +6     
  Branches     2510     2513    +3     
=======================================
+ Hits       174303   174321   +18     
+ Misses      45651    45639   -12     
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f3da50f into pola-rs:main Jan 9, 2025
22 checks passed
@alexander-beedie alexander-beedie deleted the read-spreadsheet-bytes branch January 9, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-spreadsheet Area: reading/writing Excel/ODS files fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read_Excel InvalidParametersError('source must be a string or bytes') read_excel doesn't accept bytes
2 participants